Skip to content

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Nov 24, 2025

Description

This draft PR shows how we could reorganize legacy fields.

I am not convinced that we should do this because it changes quite a few options and it can be disruptive to end users, specially given that, because of the declarative configuration, this may go in a different direction upstream and we want to stay aligned if possible.

Link to tracking issue

Fixes #14020

@mx-psi
Copy link
Member Author

mx-psi commented Nov 24, 2025

I am not convinced that we should do this because it changes quite a few options and it can be disruptive to end users, specially given that, because of the declarative configuration, this may go in a different direction upstream and we want to stay aligned if possible.

@codeboten Is this fear unfounded? Searching I could find open-telemetry/opentelemetry-specification/issues/4440 which does mention keepalives explicitly, but I don't know how to think about this

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #14203 will degrade performances by 43.39%

Comparing mx-psi:mx-psi/poc-confighttp-keepalive (4462136) with main (b5aaf8e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 4 regressions
✅ 69 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
zstdNoConcurrency 29.5 µs 52.2 µs -43.39%
BenchmarkSplittingBasedOnItemCountManySmallLogs 2.2 ms 3.2 ms -32.63%
BenchmarkLogsMarshalJSON 2.8 µs 3.9 µs -27.95%
BenchmarkTraceSizeBytes 322.9 µs 431.6 µs -25.19%

@dmitryax
Copy link
Member

dmitryax commented Nov 25, 2025

I'm supportive of this approach. I think we can finalize the migration before marking confighttp 1.0

@mx-psi
Copy link
Member Author

mx-psi commented Nov 28, 2025

I'm supportive of this approach. I think we can finalize the migration before marking confighttp 1.0

Since the OTLP exporter and the OTLP receiver are marked as 1.0 I think we would not be able to complete this migration: we can deprecate the older options but we need to keep compatibility with them until a 2.0 version of these components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[confighttp] Use configoptional for disabling keepalive section

2 participants